-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO-797] Rasa data validate does not catch domain loading as an error #12521
Merged
Urkem
merged 11 commits into
3.6.x
from
ATO-797-rasa-data-validate-does-not-catch-domain-loading-as-an-error
Jun 23, 2023
Merged
[ATO-797] Rasa data validate does not catch domain loading as an error #12521
Urkem
merged 11 commits into
3.6.x
from
ATO-797-rasa-data-validate-does-not-catch-domain-loading-as-an-error
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omain-loading-as-an-error
…omain-loading-as-an-error
ancalita
reviewed
Jun 21, 2023
…omain-loading-as-an-error
…g-as-an-error' of https://github.com/RasaHQ/rasa into ATO-797-rasa-data-validate-does-not-catch-domain-loading-as-an-error
ancalita
reviewed
Jun 22, 2023
ancalita
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻 Please add a changelog too.
…omain-loading-as-an-error
🚀 A preview of the docs have been deployed at the following URL: https://12521--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
4 tasks
Urkem
deleted the
ATO-797-rasa-data-validate-does-not-catch-domain-loading-as-an-error
branch
June 23, 2023 12:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
and
with the results. (To fix failing fast)Status (please check what you already did):
black
(please check Readme for instructions)