Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATO-797] Rasa data validate does not catch domain loading as an error #12521

Merged

Conversation

Urkem
Copy link
Contributor

@Urkem Urkem commented Jun 19, 2023

Proposed changes:

  • Fix ATO-797
  • Change to order to run the validation first and then and with the results. (To fix failing fast)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Urkem Urkem requested a review from a team as a code owner June 19, 2023 11:17
@Urkem Urkem requested a review from ancalita June 22, 2023 08:49
rasa/cli/data.py Outdated Show resolved Hide resolved
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 Please add a changelog too.

tests/cli/test_rasa_train.py Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12521--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@Urkem Urkem merged commit 2cf3c03 into 3.6.x Jun 23, 2023
@Urkem Urkem deleted the ATO-797-rasa-data-validate-does-not-catch-domain-loading-as-an-error branch June 23, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants