Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out jakarta @Valid annotations #195

Merged

Conversation

elyse-yao
Copy link
Contributor

This modifies the record processor to filter out @Valid annotations from both javax/jakarta, which fixes #189. I also added tests for both.

Note: this doesn't add support for validation using Jakarta, since that would require bumping the Hibernator version and changes to the validator/additional validators to preserve support for both validation APIs.

@elyse-yao elyse-yao marked this pull request as draft November 14, 2024 21:47
@elyse-yao elyse-yao marked this pull request as ready for review November 14, 2024 21:48
@Randgalt Randgalt added this to the v44 milestone Dec 1, 2024
@Randgalt
Copy link
Owner

Randgalt commented Dec 1, 2024

Please rebase on master and sqaush

Add test for filtering out @Valid annotations

Although validation using the Jakarta validation API is not yet supported (it would require a Hibernator version bump and likely migration away from javax validation), this adds a dependency on it to test filtering out Jakarta @Valid annotations.
@elyse-yao elyse-yao force-pushed the eyao/filter-out-jakarta-valid branch from 0a2a9d8 to 7c73324 Compare December 2, 2024 18:41
@Randgalt Randgalt merged commit 978fa4b into Randgalt:master Dec 9, 2024
2 checks passed
@elyse-yao elyse-yao deleted the eyao/filter-out-jakarta-valid branch December 9, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSR303 @Valid is not getting filtered out
2 participants