issue-122: updated add1GetterMethod logic in useImmutableCollections=true case #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add a test for this please? |
|
yes, I will add a bit late |
Randgalt
reviewed
Feb 4, 2023
| addAccessorAnnotations(component, methodSpecBuilder, __ -> true); | ||
| builder.addMethod(methodSpecBuilder.build()); | ||
| } | ||
|
|
||
| private CodeBlock build1codeBlock(RecordClassType component) { |
There was a problem hiding this comment.
Please rename checkReturnShim() or something similar
Randgalt
approved these changes
Feb 4, 2023
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #122
I am not sure that this is something exactly you would like to expect, but I reproduced and tested this case, seems it works. Would be glad to get any feedback.
Please let me know if everything is fine - I would like to take issue 123 in that case as well