Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalisation and Localisation Fixes #4017

Open
wants to merge 3 commits into
base: detour2023
Choose a base branch
from

Conversation

stuartbreckenridge
Copy link
Member

@stuartbreckenridge stuartbreckenridge commented Jun 5, 2023

  • The Keyboard Shortcuts Help page on the Mac is now internationalized and generated at run time
  • [Fix] Adds missing en-GB translations
  • [Fix] Close Image is now keyed correctly as button.title.close-image
  • [Fix] Internationalises Article Render.

New vs. Old below

New Old

@Jerry23011 Note that there are a bunch of new strings keyboard.text.<string>, keyboard.shortcut.<string>, and label.text.<multiple-selection><no-selection><loading>.

Closes #4016

- Keyboard Shortcuts on the Mac is now generated and localised at run time
- Adds missing en-GB translations
- Close Image is now keyed correctly as `button.title.close-image`

Signed-off-by: Stuart Breckenridge <[email protected]>
Signed-off-by: Stuart Breckenridge <[email protected]>
Signed-off-by: Stuart Breckenridge <[email protected]>
@stuartbreckenridge stuartbreckenridge changed the title Internationalise Keyboard Shortcuts Internationalise and Localization Fixes Jun 5, 2023
@stuartbreckenridge stuartbreckenridge changed the title Internationalise and Localization Fixes Internationalisation and Localisation Fixes Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internationalise macOS Keyboard Shortcuts
1 participant