Adding new SC and Pool for RBD #1756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshgm
force-pushed
the
drenv-multisc
branch
8 times, most recently
from
8b884a0 to
8760c02
Compare
nirs
reviewed
Jan 23, 2025
test/addons/rook-pool/start
Outdated
|
|
||
| def deploy(cluster): | ||
| scs = [ |
There was a problem hiding this comment.
storage_classes would be nicer and consistent with other names like POOL_NAMES
test/addons/rook-pool/start
Outdated
| for sc in scs: | ||
| template = drenv.template("storage-class.yaml") | ||
| yaml = template.substitute( | ||
| cluster=cluster, name=sc.get("name"), pool=sc.get("pool") |
There was a problem hiding this comment.
sc.get() will return None if we have a typo. It should be used when you want to support missing key, possibly adding a default. Since missing key is a bug in this code we want to fail loudly in this case, and the right way is:
cluster=cluster, name=sc["name"], pool=sc["pool"]
There was a problem hiding this comment.
i have made the changes.
rakeshgm
force-pushed
the
drenv-multisc
branch
from
8760c02 to
9a91484
Compare
This commit adds a new storage class and pool for RBD, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes. Signed-off-by: rakeshgm <[email protected]>
rakeshgm
force-pushed
the
drenv-multisc
branch
from
9a91484 to
56f26f0
Compare
I have updated the PR description and the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new storage class and pool for RBD, which allows the ramen code base to exercise the filtering logic when there are multiple storage classes in the environment. This also prepares the environment for scenarios where more than two workloads use different storage classes.