Fix potential bug risks and fix anti-patterns #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Remove unused imported modules [Anti-pattern]
Remove unnecessary
else
/elif
used afterreturn
orraise
return
statement causes the control flow to be disrupted, making theelse
/elif
block here unnecessary. This doesn't mean you can not use it, but it is recommended to refactor this for better readability.Remove unnecessary use of comprehension.
list
/set
/dict
out of it. Python has a specialized set of tools for this task: thelist
/set
/dict
constructors, which are faster and more readable.Changing the default arguments.