New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements #255

Merged

Raffaello merged 12 commits into master from improvemets3

Sep 28, 2023

Owner

Raffaello commented Sep 23, 2023 •

edited

Loading

MT32 requires its own dedicated midi driver
create a Timer with microseconds resolution to process MIDI events and use it for the callback not required, but some changes need to be made for rendering and in such case the opl callback as to call a callback that will send to it midi events.
create a MIDDrv using a callback instead of a thread.~ (not sure is required anymore, as it will requires a timer to process midi events on a specific interval time, so basically what the thread is already doing)
try renderer a MIDI as it is, it won't be rendered due to the thread and delay to wait to send msg. need to be reviewed
Renderer ADL Files
Renderer MIDI Files


          code rev

ee61e65

Raffaello self-assigned this

Raffaello changed the title ~~code rev~~ improvements

Raffaello added 8 commits

September 23, 2023 21:08


          code rev

1cd01d0


          code rev

bea6be3


          code rev

6bf0db3


          code rev

0d1466c


          onCallback interface definition

b632778


          OplDriver constructor passing a device instead of hardware


          MidiDriver_ADLIB construct with device instead of hardware arg

57ee058


          Sound -> PCMSound

6277c1f

Raffaello commented

View reviewed changes

sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/drivers/midi/opl/OplDriver.cpp

Comment on lines +25 to +29

+                      m_opl([&opl] {
+                          if (opl == nullptr)
+                              utils::throwLogC<std::runtime_error>("OPL device is null");
+                          return opl->getOpl();
+                      }()),

Owner Author

Raffaello Sep 27, 2023

duplicated code with MidiDriver_ADLIB .....

Raffaello added 3 commits

September 27, 2023 14:03


          code rev

c3a7fee


          renderer test

ebac81a


          code rev

e38a272

sonarqubecloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
24 Code Smells

0.0% Coverage
0.0% Duplication

Raffaello merged commit 9a17c14 into master

Raffaello deleted the improvemets3 branch

September 28, 2023 10:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet