sonarcloud code rev

Raffaello · Oct 16, 2023 · 2ebfd19 · 2ebfd19
1 parent 5e99106
commit 2ebfd19
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/devices/MT32.cpp b/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/devices/MT32.cpp
@@ -34,6 +34,11 @@ namespace HyperSonicDrivers::devices
 
     void MT32::lcd_message(const std::string& msg) noexcept
     {
-        m_mt32->sysEx(hardware::mt32::mt32_LCD_addr, reinterpret_cast<const uint8_t*>(msg.c_str()), msg.size());
+        m_mt32->sysEx(
+            hardware::mt32::mt32_LCD_addr,
+            std::bit_cast<const uint8_t*>(msg.c_str()),
+            //reinterpret_cast<const uint8_t*>(msg.c_str()),
+            static_cast<uint32_t>(msg.size())
+        );
     }
 }
diff --git a/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/drivers/midi/mt32/MT32Driver.cpp b/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/drivers/midi/mt32/MT32Driver.cpp
@@ -15,7 +15,6 @@ namespace HyperSonicDrivers::drivers::midi::mt32
             utils::throwLogC<std::runtime_error>("MT32 device is null");
 
         m_mt32 = mt32->getMt32();
-        mt32->lcd_message("test lcd");
     }
 
     MT32Driver::~MT32Driver()

diff --git a/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/hardware/mt32/MT32ReportHandler.cpp b/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/hardware/mt32/MT32ReportHandler.cpp
@@ -12,9 +12,11 @@ namespace HyperSonicDrivers::hardware::mt32
     void MT32ReportHandler::printDebug(const char* fmt, va_list list)
     {
         constexpr const int buf_size = 1024;
-        char buf[buf_size];
-        vsnprintf(buf, buf_size, fmt, list);
-        logD(std::format("{}", buf));
+        std::string buf;
+        buf.resize(buf_size);
+
+        vsnprintf(buf.data(), buf_size, fmt, list);
+        logD(buf);
     }
 
     void MT32ReportHandler::onErrorControlROM()

diff --git a/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/hardware/mt32/MT32ReportHandler.hpp b/sdl2-hyper-sonic-drivers/src/HyperSonicDrivers/hardware/mt32/MT32ReportHandler.hpp
@@ -10,6 +10,7 @@ namespace HyperSonicDrivers::hardware::mt32
     {
     public:
         MT32ReportHandler() = default;
+        ~MT32ReportHandler() = default;
 
         void printDebug(const char* fmt, va_list list) override;
         void onErrorControlROM() override;