stream: prevent stream unexpected pause when highWaterMark set to 0

Co-authored-by: Robert Nagy <[email protected]> PR-URL: nodejs#53261 Fixes: nodejs#51930 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
RafaelGSS · Jun 8, 2024 · 50695e5 · 50695e5
1 parent 5a446cc
commit 50695e5
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -565,7 +565,7 @@ function writeOrBuffer(stream, state, chunk, encoding, callback) {
     state[kState] &= ~kSync;
   }
 
-  const ret = state.length < state.highWaterMark;
+  const ret = state.length < state.highWaterMark || state.length === 0;
 
   if (!ret) {
     state[kState] |= kNeedDrain;

diff --git a/test/parallel/test-streams-highwatermark.js b/test/parallel/test-streams-highwatermark.js
@@ -85,3 +85,27 @@ const { inspect } = require('util');
              hwm,
   }));
 }
+
+{
+  const res = [];
+  const r = new stream.Readable({
+    read() {},
+  });
+  const w = new stream.Writable({
+    highWaterMark: 0,
+    write(chunk, encoding, callback) {
+      res.push(chunk.toString());
+      callback();
+    },
+  });
+
+  r.pipe(w);
+  r.push('a');
+  r.push('b');
+  r.push('c');
+  r.push(null);
+
+  r.on('end', common.mustCall(() => {
+    assert.deepStrictEqual(res, ['a', 'b', 'c']);
+  }));
+}