Added Swipe up target using vertical drag #155
+38
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome to have horizontal swipe supported as well. This feature is especially relevant when the tutorial explains which gesture to use on the target. If tutorial says "Swipe left or right to select your stage", well the user will try to swap, although only taps are currently supported... In that situation, the app doesn't react. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds onVerticalDragTargetEnd method to drag or swipeup on target.
Call function when user drag or swipe up on target and load next page using onVerticalDragTargetEnd function.
i.e Swipe up to move through the videos feed