Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for version 3.1.3 #1517

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Prepare for version 3.1.3 #1517

merged 3 commits into from
Jan 14, 2025

Conversation

bhazelton
Copy link
Member

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

Version change checklist:

  • I have updated the CHANGELOG to put all the unreleased changes under the new version (leaving the unreleased section empty).
  • I have noted any dependency changes since the last version and will update the conda package build accordingly.

No dependency changes

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (aa42351) to head (b72d9a0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          63       63           
  Lines       21852    21852           
=======================================
  Hits        21837    21837           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

steven-murray
steven-murray previously approved these changes Jan 13, 2025
Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Clearly some tests failing, so let's have a look at that...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b72d9a0 Previous: bca6cf0 Ratio
tests/utils/test_bls.py::test_bls_to_ant[min=0-len=10] 731627.4413740309 iter/sec (stddev: 0.00007576522437572569) 1493262.2171516602 iter/sec (stddev: 0.000004416881008802467) 2.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks @bhazelton all looks good to me. Soon hera_cal tests should be green :-)

@bhazelton bhazelton merged commit b582460 into main Jan 14, 2025
49 of 54 checks passed
@bhazelton bhazelton deleted the new_version branch January 14, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants