Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding the propagation_p528 #109

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

RaulMyron
Copy link

#32

@brunohcfaria
Copy link

Please fix all the lint errors reported by the github actions.

@RaulMyron RaulMyron requested review from brunohcfaria, vitorbborges and artistrea and removed request for brunohcfaria and vitorbborges November 27, 2024 16:24
sharc/parameters/parameters_rns.py Outdated Show resolved Hide resolved
sharc/propagation/propagation_factory.py Outdated Show resolved Hide resolved
tests/parameters/parameters_for_testing.yaml Outdated Show resolved Hide resolved
…e right values + added the same values in yaml file + added nested reader in the parameters_rns + added Union elements in the default parameters_p528 + changed the function name for read parameters (btw it's wrong in the p619)
@RaulMyron RaulMyron requested a review from artistrea November 30, 2024 03:57
@RaulMyron
Copy link
Author

btw the conflicts in test_parameters.py are generated because of the linting and black actuation in the test_parameters.py file

@RaulMyron
Copy link
Author

  • a doubt I don't know if the actuation in propagation_factory is correct, pls see it.

@brunohcfaria
Copy link

@RaulMyron Please fix the lint error before we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants