forked from SIMULATOR-WG/SHARC
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding the propagation_p528 #109
Open
RaulMyron
wants to merge
9
commits into
Radio-Spectrum:development
Choose a base branch
from
RaulMyron:p528
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix all the lint errors reported by the github actions. |
RaulMyron
requested review from
brunohcfaria,
vitorbborges and
artistrea
and removed request for
brunohcfaria and
vitorbborges
November 27, 2024 16:24
artistrea
requested changes
Nov 27, 2024
…e right values + added the same values in yaml file + added nested reader in the parameters_rns + added Union elements in the default parameters_p528 + changed the function name for read parameters (btw it's wrong in the p619)
btw the conflicts in test_parameters.py are generated because of the linting and black actuation in the test_parameters.py file |
|
@RaulMyron Please fix the lint error before we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32