Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test #8

wants to merge 1 commit into from

Conversation

bridgecrew-dev[bot]
Copy link

Bridgecrew has created this PR to fix one or more resources in the infrastructure files of this project.

Changes included in this PR:

  • /terraform/modules/storage/main.tf:module.storage.aws_ssm_parameter.example_ssm_db_password
  • /terraform/modules/storage/main.tf:module.storage.aws_ssm_parameter.example_ssm_db_name

Below are the Policies fixed in this PR:

🌈 Policy ✨ Details
Ensure SSM parameters are using KMS CMK View
Please check the changes in this PR to ensure they do not introduce conflicts to your project.

For more information:
View this repository's Supply Chain Graph👀

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@@ -168,6 +169,7 @@ resource "aws_ssm_parameter" "example_ssm_db_name" {
git_repo = "codegoat"
yor_trace = "f6cfbef0-a5d1-4630-a933-52adf04af603"
})
key_id = "CKV_ANY"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  AWS SSM Parameter is not encrypted
    Resource: aws_ssm_parameter.example_ssm_db_name | Checkov ID: CKV2_AWS_34

How to Fix

resource "aws_ssm_parameter" "aws_ssm_parameter_ok" {
 name            = "sample"
* type            = "SecureString"
 value           = "test"
 description     = "policy test"
 tier            = "Standard"
 allowed_pattern = ".*"
 data_type       = "text"
}

Description

As a best practice enable encryption for your AWS SSM Parameter to improve data security without making changes to your business or applications.

@@ -131,6 +131,7 @@ resource "aws_ssm_parameter" "example_ssm_db_password" {
git_repo = "codegoat"
yor_trace = "d066cbee-4067-495c-8377-3294ec8f5509"
})
key_id = "CKV_ANY"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  AWS SSM Parameter is not encrypted
    Resource: aws_ssm_parameter.example_ssm_db_password | Checkov ID: CKV2_AWS_34

How to Fix

resource "aws_ssm_parameter" "aws_ssm_parameter_ok" {
 name            = "sample"
* type            = "SecureString"
 value           = "test"
 description     = "policy test"
 tier            = "Standard"
 allowed_pattern = ".*"
 data_type       = "text"
}

Description

As a best practice enable encryption for your AWS SSM Parameter to improve data security without making changes to your business or applications.

@@ -168,6 +169,7 @@ resource "aws_ssm_parameter" "example_ssm_db_name" {
git_repo = "codegoat"
yor_trace = "f6cfbef0-a5d1-4630-a933-52adf04af603"
})
key_id = "CKV_ANY"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  AWS SSM Parameter is not encrypted
    Resource: module.storage.aws_ssm_parameter.example_ssm_db_name | Checkov ID: CKV2_AWS_34

How to Fix

resource "aws_ssm_parameter" "aws_ssm_parameter_ok" {
 name            = "sample"
* type            = "SecureString"
 value           = "test"
 description     = "policy test"
 tier            = "Standard"
 allowed_pattern = ".*"
 data_type       = "text"
}

Description

As a best practice enable encryption for your AWS SSM Parameter to improve data security without making changes to your business or applications.

@@ -131,6 +131,7 @@ resource "aws_ssm_parameter" "example_ssm_db_password" {
git_repo = "codegoat"
yor_trace = "d066cbee-4067-495c-8377-3294ec8f5509"
})
key_id = "CKV_ANY"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  AWS SSM Parameter is not encrypted
    Resource: module.storage.aws_ssm_parameter.example_ssm_db_password | Checkov ID: CKV2_AWS_34

How to Fix

resource "aws_ssm_parameter" "aws_ssm_parameter_ok" {
 name            = "sample"
* type            = "SecureString"
 value           = "test"
 description     = "policy test"
 tier            = "Standard"
 allowed_pattern = ".*"
 data_type       = "text"
}

Description

As a best practice enable encryption for your AWS SSM Parameter to improve data security without making changes to your business or applications.

Copy link
Author

@bridgecrew-dev bridgecrew-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

@@ -168,6 +169,7 @@ resource "aws_ssm_parameter" "example_ssm_db_name" {
git_repo = "codegoat"
yor_trace = "f6cfbef0-a5d1-4630-a933-52adf04af603"
})
key_id = "CKV_ANY"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS SSM Parameter is encrypted
    Resource: aws_ssm_parameter.example_ssm_db_name | Bridgecrew ID: BC_AWS_GENERAL_143 | Checkov ID: CKV2_AWS_34

@@ -131,6 +131,7 @@ resource "aws_ssm_parameter" "example_ssm_db_password" {
git_repo = "codegoat"
yor_trace = "d066cbee-4067-495c-8377-3294ec8f5509"
})
key_id = "CKV_ANY"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS SSM Parameter is encrypted
    Resource: aws_ssm_parameter.example_ssm_db_password | Bridgecrew ID: BC_AWS_GENERAL_143 | Checkov ID: CKV2_AWS_34

@@ -131,6 +131,7 @@ resource "aws_ssm_parameter" "example_ssm_db_password" {
git_repo = "codegoat"
yor_trace = "d066cbee-4067-495c-8377-3294ec8f5509"
})
key_id = "CKV_ANY"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS SSM Parameter is encrypted
    Resource: module.storage.aws_ssm_parameter.example_ssm_db_password | Bridgecrew ID: BC_AWS_GENERAL_143 | Checkov ID: CKV2_AWS_34

@@ -168,6 +169,7 @@ resource "aws_ssm_parameter" "example_ssm_db_name" {
git_repo = "codegoat"
yor_trace = "f6cfbef0-a5d1-4630-a933-52adf04af603"
})
key_id = "CKV_ANY"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Ensure AWS SSM Parameter is encrypted
    Resource: module.storage.aws_ssm_parameter.example_ssm_db_name | Bridgecrew ID: BC_AWS_GENERAL_143 | Checkov ID: CKV2_AWS_34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants