Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 57 error due to refactoring of cd to working directory by ebcpy #58

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Issue 57 error due to refactoring of cd to working directory by ebcpy #58

merged 3 commits into from
Apr 15, 2024

Conversation

HvanderStok
Copy link
Contributor

Closes #57 and refactor cd to working_directory in all classes.

FWuellhorst
FWuellhorst approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we have to wait for CI to mirror again.

@FWuellhorst
Copy link
Collaborator

@jkriwet checked locally to see if #60 works, I will merge this without CI passing as the error seems persistent in gitlab.

@FWuellhorst FWuellhorst merged commit 3439498 into master Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error due to refactoring of cd to working_directory by ebcpy
2 participants
@HvanderStok @FWuellhorst