Skip to content

Commit

Permalink
Corrected an error in lefWrite where SelectClear() is called
Browse files Browse the repository at this point in the history
without SelectRootDef being set, which causes SelectClear() to
return without doing anything.  However---question is why
SelectClear() needs SelectRootDef to be non-NULL since it is
clearing the selection, not the selection source.  For now, just
patching the failing case, not trying to mess with the whole
selection mechanism.
  • Loading branch information
RTimothyEdwards committed Mar 8, 2024
1 parent eeeaf49 commit cb73ebf
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions lef/lefWrite.c
Original file line number Diff line number Diff line change
Expand Up @@ -1496,6 +1496,11 @@ lefWriteMacro(def, f, scale, setback, pinonly, toplayer, domaster)
Rect carea;
labelLinkedList *newlll;

/* SelectClear() requires SelectRootDef be non-NULL, although
* this might be an error in SelectClear(), since SelectClear()
* clears the selection, not the source.
*/
if (SelectRootDef == NULL) SelectRootDef = lefFlatDef;
SelectClear();
if (pinonly == 0)
carea = labr;
Expand Down

0 comments on commit cb73ebf

Please sign in to comment.