-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components][driver]add phy and mdio bus #9524
base: master
Are you sure you want to change the base?
Conversation
…er writer can write phy_driver first .when mac driver need to use phy they can register phy_device and pjhy_devie will serach for driver which match by uid and mask,if no driver match with the device that you register,phy_bus will return the genphy to you device,the genphy driver is the general driver for phy,so you can use it but it can not support the capcity of chip it may be cause performance is not up to peak
#9470 (comment) |
请不要随意标resolved,上面问题还没解决 |
@zhuzhuzhus PR有冲突了,帮忙解决下 |
ok啦 |
#include <rtdevice.h> | ||
|
||
#define DBG_TAG "PHY" | ||
#include <drivers/phy.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13、14行统一 #include rtdevice.h 就行
@@ -8,6 +8,11 @@ | |||
* 2024-09-25 zhujiale the first version | |||
*/ | |||
#include <rtthread.h> | |||
#include <drivers/phy.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块也是,引用rtdevice.h就行
#include <rtthread.h> | ||
#include <drivers/phy.h> | ||
|
||
#define RT_MDIO_DEVAD_NONE (-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释看着乱乱的,可以格式化下吗?
#ifndef __PHY_MDIO_H__ | ||
#define __PHY_MDIO_H__ | ||
#include <rtthread.h> | ||
#include <drivers/phy.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include rtdevice.h
#ifndef __PHY_GENERAL_H__ | ||
#define __PHY_GENERAL_H__ | ||
/* The forced speed, 10Mb, 100Mb, gigabit, 2.5Gb, 10GbE. */ | ||
#define SPEED_10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件的注释也格式化下吧
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
old phy bus is too simple add phy_bus is not adapt rt_bus framework,so writer a stronger phy bus framework.
here is my commit message:
add mdio bus and phy bus to kernel,the phy bus use rt_bus framewok ,driver writer can write phy_driver first .when mac driver need to use phy they can register phy_device and pjhy_devie will serach for driver which match by uid and mask,if no driver match with the device that you register,phy_bus will return the genphy to you device,the genphy driver is the general driver for phy,so you can use it but it can not support the capcity of chip it may be cause performance is not up to peak
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
BSP: rk3568
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up