Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][nuvoton][rsoc] Fix compilation issues with bsp of nuvoton series #9481

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented Sep 27, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

修复了nuvoton系列bsp的编译问题

你的解决方案是什么 (what is your solution)

根据报错提示进行修改

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    nuvoton/numaker-pfm-m487
    nuvoton/numaker-hmi-ma35d1
    nuvoton/numaker-iot-m487
    nuvoton/numaker-m032ki
    nuvoton/numaker-iot-m467
    nuvoton/numaker-m467hj
    nuvoton/nk-n9h30
    nuvoton/nk-rtu980
    nuvoton/ma35-rtp
    nuvoton/nk-980iot
    nuvoton/numaker-iot-ma35d1
    nuvoton/numaker-m2354
  • .config:
    CONFIG_RT_VER_NUM=0x50200
    numaker-hmi-ma35d1:
    CONFIG_PKG_USING_LVGL=n
    CONFIG_PKG_USING_WAVPLAYER=n
    CONFIG_PKG_USING_RAMDISK=n
    CONFIG_PKG_USING_OPTPARSE=n
    numaker-m467hj:
    CONFIG_PKG_USING_WAVPLAYER=n
    CONFIG_PKG_USING_RAMDISK=n
    CONFIG_PKG_USING_OPTPARSE=n
    nk-n9h30:
    CONFIG_PKG_USING_LVGL=n
    CONFIG_PKG_USING_RAMDISK=n
    nk-rtu980:
    CONFIG_PKG_USING_RAMDISK=n
    CONFIG_PKG_USING_OPTPARSE=n
    nk-980iot:
    CONFIG_PKG_USING_WAVPLAYER=n
    CONFIG_PKG_USING_RAMDISK=n
    CONFIG_PKG_USING_OPTPARSE=n
    numaker-iot-ma35d1:
    CONFIG_PKG_USING_WAVPLAYER=n
    CONFIG_PKG_USING_RAMDISK=n
    CONFIG_PKG_USING_OPTPARSE=n
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@@ -603,25 +606,25 @@ static int nu_pipe_xfer(upipe_t pipe, rt_uint8_t token, void *buffer, int nbytes
}
else if (pipe->ep.bmAttributes == USB_EP_ATTR_ISOC)
{
//TODO: ISO transfer
/*TODO: ISO transfer*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/* xx */ 左右有空格

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已对相关文件修改

@supperthomas
Copy link
Member

supperthomas commented Sep 28, 2024

感谢大佬修复, ci 请帮忙加到bsp_buildings.yml文件中

@hydevcode
Copy link
Contributor Author

hydevcode commented Sep 28, 2024

感谢大佬修复, ci 请帮忙加到bsp_buildings.yml文件中

已经加进去了

@hydevcode hydevcode marked this pull request as ready for review September 28, 2024 06:40
@hydevcode hydevcode marked this pull request as draft September 28, 2024 06:53
@hydevcode hydevcode marked this pull request as ready for review September 28, 2024 07:19
@supperthomas
Copy link
Member

这个component 另外起一个PR提交。和bsp不相关

@hydevcode
Copy link
Contributor Author

这个component 另外起一个PR提交。和bsp不相关

已修改

@mysterywolf mysterywolf merged commit e7e44ec into RT-Thread:master Sep 30, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants