Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][nxp][rsoc] Fix compilation issues with bsp of nxp/lxp series #9474

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented Sep 26, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

修复了nxp/lxp系列bsp的编译问题

你的解决方案是什么 (what is your solution)

根据报错的内容进行修复

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/nxp/lpc/lpc5410x bsp/nxp/lpc/lpc54114-lite
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@github-actions github-actions bot added BSP: NXP Code related with NXP BSP labels Sep 26, 2024
@kurisaW
Copy link
Contributor

kurisaW commented Sep 26, 2024

标题建议命名:[bsp][nxp][rsoc] Fix compilation issues with bsp of nxp/lxp series

@hydevcode hydevcode marked this pull request as draft September 26, 2024 06:09
@hydevcode hydevcode changed the title [bsp][rsoc] Fix compilation issues with bsp of nxp/lxp series [bsp][nxp][rsoc] Fix compilation issues with bsp of nxp/lxp series Sep 26, 2024
@hydevcode hydevcode marked this pull request as ready for review September 26, 2024 06:25
@kurisaW
Copy link
Contributor

kurisaW commented Sep 26, 2024

可以压缩成一个提交

@hydevcode hydevcode marked this pull request as draft September 26, 2024 11:04
@hydevcode hydevcode marked this pull request as ready for review September 26, 2024 15:40
@hydevcode
Copy link
Contributor Author

可以压缩成一个提交

已压缩

@supperthomas
Copy link
Member

ci可以加一下试下

@hydevcode hydevcode marked this pull request as draft September 27, 2024 06:35
@hydevcode
Copy link
Contributor Author

ci可以加一下试下

已经将不符合格式的代码修改好了

@supperthomas
Copy link
Member

ci可以加一下试下

已经将不符合格式的代码修改好了

.github/bsp_buildings.yml 添加bsp

@hydevcode hydevcode marked this pull request as draft September 27, 2024 17:24
@github-actions github-actions bot added the action github action yml imporve label Sep 27, 2024
@hydevcode
Copy link
Contributor Author

ci可以加一下试下

已经将不符合格式的代码修改好了

.github/bsp_buildings.yml 添加bsp

已添加

@hydevcode hydevcode marked this pull request as ready for review September 27, 2024 17:54
@mysterywolf mysterywolf merged commit 66d54ea into RT-Thread:master Sep 30, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP: NXP Code related with NXP BSP component: drivers Component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants