-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsp/cvitek] Update packaging method #9457
Conversation
Use pre-build files to reduce compilation time Signed-off-by: flyingcys <[email protected]>
ci好加吗? |
关于这个打包的 issue,我以前建过一个 #9060 ,用于讨论 solution 和可行性。 如果大家觉得引入 prebuild 的做法可以继续,那我也没有意见(这个 pr 我也看了,按这个思路做的改动本身没有什么大的问题),只是个人觉得这不是个好的 solution。 Anyway,其实对于一些 feature 的开发,我的建议是先建立 issue ,充分讨论后再开发和 pr。否则直接 pr 后再讨论要不要做的确是一件很尴尬的事情。 谁可以决定这个事情呢?可以拍个板。 |
|
CI已经添加一个 |
当前pre-build 增加文件大小为2.9M空间。 |
采用预编译好的bin文件的方式,还有什么问题吗 |
Use pre-build files to reduce compilation time
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
修改cvitek 打包方式为预编译文件
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up