-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[src][thread]update change prio func #9358
base: master
Are you sure you want to change the base?
Conversation
重新触发静态检查。 |
Change current priority 这个API是否可以作为static私有函数?因为用户不会寄希望说改变current priority, 然后不确定什么时候 current priority又会被莫名其妙的还原。current priority 应该是内部信息,用户不需要感知。 |
直接重新规范rt_sched_thread_change_priority语义就可以了,rt_sched_thread_change_priority就是change init_priority,即标题说的永久优先级,用户也不需要管我当前是否有mutex,反正设置完成之后 优先级就会改变就是了。 |
主要是mutex用了这个函数,mutex和chang prio不在一个文件里面,所以没用static |
因此这个 PR 的意图也主要是纠正通过 rt_thread_control 修改线程优先级(rt_thread_control -> rt_sched_thread_change_priority)的实现。 |
@zmshahaha @polarvid OK 麻烦 把这两个注释写全,写清楚这两个函数的功能,以及强调一下一般用户不会用到change_current_priority这个函数,这个函数实际是一个内部函数,受限使用,除非其完全理解内核的意义。 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
之前的优先级调整只调整current_priority,但mutex获取时会临时改变优先级,解锁后会恢复为init_prio,导致优先级更新失效
你的解决方案是什么 (what is your solution)
分离临时调整优先级以及永久调整优先级api,其中永久调整优先级的api在线程释放所有持有的mutex后才生效
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up