Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components][SPI][spi-bit-ops]修复可能的异常操作 #9124

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wdfk-prog
Copy link
Contributor

@wdfk-prog wdfk-prog commented Jun 30, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  1. [components][SPI][spi-bit-ops]修复可能的异常操作]
  2. [components][drivers][spi]重命名spi.h为spi_core.h
  3. [STM32][SPI]根据频率计算收发超时时间
  4. [STM32][SPI]移除内部编写的延时函数使用统一延时接口

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP: STM32H750
  • action:

spi.h 修改为spi_core.h 防止bsp中包含同样名称.h导致编译异常

[[STM32][SPI]根据频率计算收发超时时间] 编写测试 W25Q128 FLASH正常 读取

模拟SPI编译通过,未进行实际测试;

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

mysterywolf commented Jul 11, 2024

我觉得1、2commit没有问题,3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

@wdfk-prog
Copy link
Contributor Author

我觉得1、2commit没有问题,3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

行;第3个commit的话,最少也得把这个头文件宏改掉,不然肯定有问题

#ifndef __SPI_H__
#define __SPI_H__
#endif

@wdfk-prog
Copy link
Contributor Author

我觉得1、2commit没有问题,3、4commit需要再讨论一下。我先把1、2commit cherry-pick到仓库了 #9177

第4个的话,应该来说SPI没有啥速率规定;现在仅用了一个常规条件下能够接收的超时时间;
换成计算的方式会更好

@mysterywolf
Copy link
Member

mysterywolf commented Aug 13, 2024

第3个commit的话,最少也得把这个头文件宏改掉,不然肯定有问题

#9301

@mysterywolf
Copy link
Member

#9420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants