-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues with timerfd #8102
Merged
BernardXiong
merged 2 commits into
RT-Thread:master
from
zmq810150896:rt-thread_timerfd
Oct 13, 2023
Merged
Fixed issues with timerfd #8102
BernardXiong
merged 2 commits into
RT-Thread:master
from
zmq810150896:rt-thread_timerfd
Oct 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmq810150896
force-pushed
the
rt-thread_timerfd
branch
from
September 28, 2023 05:59
c261103
to
79c0dc9
Compare
BernardXiong
requested changes
Oct 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
从名称上来说,timerfd_create_do
可以更改成timerfd_do_create
|
zhkag
reviewed
Oct 8, 2023
zmq810150896
force-pushed
the
rt-thread_timerfd
branch
2 times, most recently
from
October 8, 2023 09:36
2154ced
to
04df3de
Compare
给出更多的测试用例吧 |
utest 那边有办法加这个的测试用例吗? 有的话加上 |
|
zmq810150896
force-pushed
the
rt-thread_timerfd
branch
2 times, most recently
from
October 10, 2023 09:56
2e5530e
to
6d62051
Compare
zmq810150896
force-pushed
the
rt-thread_timerfd
branch
from
October 10, 2023 11:08
6d62051
to
cf68526
Compare
geniusgogo
approved these changes
Oct 12, 2023
BernardXiong
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为什么提交这份PR (why to submit this PR)
修复在用户态获取当前时间之后,调用到内核态再次获取当前时间,两边差值为负数,定时器不会运行的问题、
在什么测试环境下测试通过 (what is the test environment)
qemu-virt64-aarch64
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up