Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with timerfd #8102

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

zmq810150896
Copy link
Contributor

@zmq810150896 zmq810150896 commented Sep 28, 2023

为什么提交这份PR (why to submit this PR)

修复在用户态获取当前时间之后,调用到内核态再次获取当前时间,两边差值为负数,定时器不会运行的问题、

在什么测试环境下测试通过 (what is the test environment)

qemu-virt64-aarch64

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

从名称上来说,timerfd_create_do可以更改成timerfd_do_create

components/libc/posix/io/timerfd/timerfd.c Outdated Show resolved Hide resolved
components/libc/posix/io/timerfd/timerfd.c Outdated Show resolved Hide resolved
@BernardXiong
Copy link
Member

rt_thread_t timerfd_thread; 也可以考虑更改成tidowner_thread。另外,对于fd操作需要多考虑到互斥性

@zhkag zhkag added the -1 No vote label Oct 8, 2023
@zmq810150896 zmq810150896 force-pushed the rt-thread_timerfd branch 2 times, most recently from 2154ced to 04df3de Compare October 8, 2023 09:36
@zhkag zhkag added +1 Agree +1 and removed -1 No vote labels Oct 8, 2023
@BernardXiong
Copy link
Member

给出更多的测试用例吧

@zhkag
Copy link
Member

zhkag commented Oct 9, 2023

utest 那边有办法加这个的测试用例吗? 有的话加上

@zmq810150896
Copy link
Contributor Author

给出更多的测试用例吧
测试用例后面上传到测试仓库
utest 那边有办法加这个的测试用例吗? 有的话加上
应该是可以加的,后面看看能不能加上

@zmq810150896 zmq810150896 force-pushed the rt-thread_timerfd branch 2 times, most recently from 2e5530e to 6d62051 Compare October 10, 2023 09:56
@geniusgogo geniusgogo added the +2 Agree +2 label Oct 12, 2023
@BernardXiong BernardXiong merged commit a289ae1 into RT-Thread:master Oct 13, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1 +2 Agree +2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants