feat: read image proxy url from ab value

RSSNext · Sep 20, 2024 · d81f57d · d81f57d
1 parent 7f3b787
commit d81f57d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/apps/renderer/src/hooks/biz/useAb.ts b/apps/renderer/src/hooks/biz/useAb.ts
@@ -17,8 +17,9 @@ export const useAb = (feature: FeatureKeys) => {
   return isEnabled
 }
 
-export const getAbValue = (feature: FeatureKeys) => {
-  const enabled = PostHog.getFeatureFlag(feature)
+export const isAbEnabled = (feature: FeatureKeys) => {
+  const featureFlag = PostHog.getFeatureFlag(feature)
+  const enabled = typeof featureFlag === "boolean" ? featureFlag : featureFlag === "enabled"
   const debugOverride = jotaiStore.get(debugFeaturesAtom)
 
   const isEnableOverride = jotaiStore.get(enableDebugOverrideAtom)
@@ -29,3 +30,7 @@ export const getAbValue = (feature: FeatureKeys) => {
 
   return enabled
 }
+
+export const getAbValue = (feature: FeatureKeys) => {
+  return PostHog.getFeatureFlagPayload(feature)
+}
diff --git a/apps/renderer/src/lib/img-proxy.ts b/apps/renderer/src/lib/img-proxy.ts
@@ -1,7 +1,6 @@
-import { env } from "@follow/shared/env"
 import { imageRefererMatches } from "@follow/shared/image"
 
-import { getAbValue } from "~/hooks/biz/useAb"
+import { getAbValue, isAbEnabled } from "~/hooks/biz/useAb"
 
 export const getImageProxyUrl = ({
   url,
@@ -12,10 +11,10 @@ export const getImageProxyUrl = ({
   width: number
   height: number
 }) => {
-  if (getAbValue("Image_Proxy_V2")) {
-    return `${env.VITE_IMGPROXY_URL}?url=${encodeURIComponent(url)}&width=${width}&height=${height}`
+  if (isAbEnabled("Image_Proxy_V2")) {
+    return `${getAbValue("Image_Proxy_V2")}?url=${encodeURIComponent(url)}&width=${width}&height=${height}`
   } else {
-    return `${env.VITE_IMGPROXY_URL}/unsafe/fit-in/${width}x${height}/${encodeURIComponent(url)}`
+    return `${getAbValue("Image_Proxy_V2")}/unsafe/fit-in/${width}x${height}/${encodeURIComponent(url)}`
   }
 }