Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] add dynamic list with ajax requests #4361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

floviolleau
Copy link
Contributor

@floviolleau floviolleau commented Dec 8, 2024

Hi!

The goal of this PR here is to be able to have dynamic lists for parameters.
It introduces a new type for parameters: dynamic_list.

This feature is to answer to some bridges that have big select / options in parameters.

I'm using datalist tag described here: https://www.w3schools.com/tags/tag_datalist.asp).

An example of usage can be seen here: #4362 and #4363

Kind regards

@dvikan
Copy link
Contributor

dvikan commented Dec 12, 2024

yes i can see how this is useful.

but that javascript inside html tag is not good. can you move it out to the .js file we already have?

the rest im unsure of. will take a closer look

@floviolleau
Copy link
Contributor Author

Hi,

I wasn't sure about how to add a js file inside the project. If you can guide how to do that?

Thanks!

@dvikan
Copy link
Contributor

dvikan commented Dec 13, 2024

i'd prefer you add a function to the already existing file static/rss-bridge.js

but, using that thirdparty CORS proxy is not good. also did you test if the config proxy works? last time i tried, i could not get proxy to work.

ideally the ajax should go towards rssbridge. not relying on thirdparty.

@floviolleau
Copy link
Contributor Author

Hi,

Yes I will do that for the function and retest.

I agree with you, 3rd party proxy is not good at all. Yes I tested it and proxy config works!

Do you know an endpoint that can do the same in RSS-Bridge or we have to create a new one?

@dvikan
Copy link
Contributor

dvikan commented Dec 13, 2024

to do this properly i think we should add a new function to BridgeAbstract: getDynamicData(), then the javascript could do ajax towards a new route/action and then fill in the list for autocomplete.

i think it be better if I implement this. but still feel free to try yourself and create PR. i dont have time now but in the next few weeks i can give it a go

@floviolleau
Copy link
Contributor Author

floviolleau commented Dec 16, 2024

Hi,

Sounds like a plan 😉!

Sur Xmax is coming and we will be all busy 🎄 🎅 .

I will wait your new endpoint and update this PR accordingly once done.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants