Skip to content

Generic dialog fixes #5432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2025
Merged

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented May 13, 2025

Identify the Bug or Feature request

fixes #4107, #5376, #5423
advances #5147

Description of the Change

Maximise button removed
Changes to force fit dialog on available screen-space.

Possible Drawbacks

Things work differently for different people.
Reduced accessibility.

Documentation Notes

General dialog improvements to prevent them exceeding screen size.

Release Notes

General dialog fixes.


This change is Reviewable

between OSes.
Changed SwingUtil.centerOver to enforce not overlapping screen insets.
Changed GenericDialog layout to never exceed the available screen space.
@github-actions github-actions bot added the feature Adding functionality that adds value label May 13, 2025
@bubblobill bubblobill requested a review from kwvanderlinde May 13, 2025 13:00
@bubblobill
Copy link
Collaborator Author

@kwvanderlinde
It isn't perfect yet, but it puts us back in a good starting position.
Main problem is it doesn't quite do layout correctly for sizing some smaller dialogs, i.e. The scroll-pane shows a scroll-bar when there is ample space to expand. I was mostly concerned with fixing the oversize going off the screen issue.

@bubblobill bubblobill self-assigned this May 13, 2025
@kwvanderlinde kwvanderlinde moved this from Todo to Awaiting-Review in MapTool 1.18 May 14, 2025
@kwvanderlinde kwvanderlinde linked an issue May 14, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this from Awaiting-Review to To-Be-Merged in MapTool 1.18 May 15, 2025
@kwvanderlinde kwvanderlinde added this pull request to the merge queue May 15, 2025
Merged via the queue into RPTools:develop with commit b5ae773 May 15, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from To-Be-Merged to Merged in MapTool 1.18 May 15, 2025
Copy link

sentry-io bot commented May 17, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NullPointerException: Cannot invoke "com.jidesoft.dialog.StandardDialog.getDialogResult()" net.rptools.maptool.client.swing.MapToolEventQu... View Issue
  • ‼️ ConcurrentModificationException net.rptools.maptool.client.walker.AbstractZoneW... View Issue
  • ‼️ ClassCastException: class javax.swing.JLabel cannot be cast to class com.jidesoft.grid.PropertyTable (javax.swing.JLabel is in module java.desktop of loader 'bootstrap'; com.jidesoft.grid.PropertyTable is in unnamed module of loader 'app') net.rptools.maptool.client.ui.token.dialog.edit... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug]: Stray maximize button in some dialogs [Feature]: Limit dialogue boxes to screen boundaries
2 participants