Fix Zip Slip vulnerability in file extraction utility #5422
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fix Zip Slip vulnerability in file extraction utility
#5421
Description of the Change
Provide path validation, ensuring files can only be extracted within the intended path directory/ Path canonicalisation to prevent bypass techniques. Added try-with-resources to ensure proper stream colsure, preventing resource leaks. The code extracts content only after verifying that the path is safe.
This vulnerability was also found in YANG-DB/yang-db@4c32a32 and fixed henceforth,
Documentation Notes
Release Notes
Fix Zip Slip vulnerability in file extraction utility
This change is