Token layout tab - nerfed version #5360
Conversation
clean up some property names, e.g. isFlippedIso to flippedIso so that getter becomes isFlippedIso(). Unnecessary Token removed from property tokenOpacity. Now just opacity. Reordered to keep layout props together. Added new layout prop imageRotation Updated tokenLayoutProp macro functions
…ented code. Commented code removed
Token drawing moved to TokenRenderer Facing-arrow painting moved to FacingArrowRenderer Some functionality moved to ImageUtils
Remove old layout panel
Icons embedded
. Added floor and ceiling properties to the numeric model instead. Major rework of SpinnerSliderPaired Spotless and tweaks
bubblobill
requested review from
kwvanderlinde and
cwisniew
and removed request for
kwvanderlinde
Fixed problem with slider not updating in SpinnerSliderPaired with mouse wheel event
There was a problem hiding this comment.
I like how it looks. There's just one bug to chase down yet before merging.
When I set offsets, the selection box for the token is offset by the expected amount, but the token image is offset by twice that amount. E.g., if I place a token here on a 100x100 grid:
Then set the offsets to -50, -50, this is what happens
And this is what should happen, and which is what happens on 1.16.2:
Which is mostly right because this ->
is wrong. What you should be seeing is this
The token layout should primarily be used for correcting the image placement within the cell, i.e. its apparent position. example, a little zoom and some offset makes this guy fill the space and leaves his arm out in the cold.: Changing the actual position of the token is not related to the layout. Changing the actual position of the token relative to its footprint should be handled in footprints. Part of a whole bundle of follow-on improvements to go with implementing the new footprint stuff. Check the new commit which leaves the selection marquee where it belongs. |
Identify the Bug or Feature request
resolves #5097
Description of the Change
Cut down version of the changes in #5104
This PR makes no changes to the token class and does not implement independant scaling by axes or rotation of the token image.
Possible Drawbacks
It is lame
Documentation Notes
Moved token layout panel to its own tab
Release Notes
Moved token layout panel to its own tab
This change is