-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5139 added prior mapID to onChangeMap #5140
base: develop
Are you sure you want to change the base?
Conversation
I placed the priorMapID above some error checks causing inconsistent results.
@Jmr3366 have you tested this when loading a new campaign because I think this might send the zone id of the previous campaign |
Yes Sir, you are correct. I did test loading a campaign several times but it was the same one and I didn't catch that. Let me dig deeper |
# Conflicts: # src/main/java/net/rptools/maptool/events/ZoneLoadedListener.java
Added checks to confirm zoneID
@cwisniew I added the checks to When I load a campaign fresh from a MT closed state, it triggers every time (eg close MT, open it, load a camp.). -edit/updated- Test process: fresh build running via ide New Camp, add library token, add Closing MT resets this. |
Identify the Bug or Feature request
#5139 to add prior mapID.
Description of the Change
When using the
onChangeMap
event, the output will now include both the going to mapID and the coming from mapIDPossible Drawbacks
There is a change in the macro.args passed output so any macro that does not account for two string parameters will likely fail and/or generate an error.
Release Notes
When the
onChangeMap
macro code is executed per the wiki,it will now return two map ID's
landing mapID, launched from mapID
This change is