Skip to content

Commit

Permalink
Check isHidden() when dispatching HTML events to frames
Browse files Browse the repository at this point in the history
For dockable frames, the component itself is hidden if not the active tab so AWT's `isVisible()` returns false. However
JIDE and the user consider the frame still open, which agrees with `!isHidden()`.
  • Loading branch information
kwvanderlinde committed May 28, 2024
1 parent 52c493c commit 70b9c56
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ public void updateContents(
/** Run all callback macros for "onChangeSelection". */
public static void doSelectedChanged() {
for (HTMLFrame frame : frames.values()) {
if (frame.isVisible()) {
if (!frame.isHidden()) {
HTMLPanelContainer.selectedChanged(frame.macroCallbacks);
}
}
Expand All @@ -319,7 +319,7 @@ public static void doSelectedChanged() {
/** Run all callback macros for "onChangeImpersonated". */
public static void doImpersonatedChanged() {
for (HTMLFrame frame : frames.values()) {
if (frame.isVisible()) {
if (!frame.isHidden()) {
HTMLPanelContainer.impersonatedChanged(frame.macroCallbacks);
}
}
Expand All @@ -333,7 +333,7 @@ public static void doImpersonatedChanged() {
public static void doTokenChanged(Token token) {
if (token != null) {
for (HTMLFrame frame : frames.values()) {
if (frame.isVisible()) {
if (!frame.isHidden()) {
HTMLPanelContainer.tokenChanged(token, frame.macroCallbacks);
}
}
Expand Down

0 comments on commit 70b9c56

Please sign in to comment.