More accurate PS3 memory consumption #12747
Open
+281
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when are you going to merge this? |
|
Probably not anytime soon due to lack of hw testing capabilities. |
|
Are we able to assist in the HW tests? |
|
Yes |
|
No. |
|
By Hardware tests, Elad means with a devkit not with a regular PlayStation 3. And the person who has a devkit our devs remote into for testing is currently moving house so it isn't online. |
This comment was marked as resolved.
This comment was marked as resolved.
elad335
force-pushed
the
ps3-mem
branch
2 times, most recently
from
22a9502 to
1d9ab8e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Games are booting again and Max Payne 3 is back to the same compatibility as master. |
|
Was this ever tested on the dev kit? This seems like a good set of changes. |
I see the PR is out of draft. How did the hardware tests go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take the following into the total reported and observed PS3 memory amount:
Makes Brink fail to execute some bugged and unused audio code that used to crash it on rpcs3 because now the memory allocations required for it fail and the whole section is skipped.
Fixes #11945
Draft because needs proper hw tests.