-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more 8ball commands. #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to maintain positive-to-neutral-to-negative balance of 3:2:3, keep slight variations to a minimum, and update response counters in the comments to make the ratio tracking easier
Co-Authored-By: Ilya <[email protected]>
Co-Authored-By: Ilya <[email protected]>
Hi 13xforever Thanks for the comments, I'm still just getting started at the moment. I've resolved my commits based on your comments. Does that seem ok now? Thanks! |
@cgunston can you squash everything to one commit? I'd prefer this to be an atomic change, and I don't want to use autosquash on github as it will change the author |
@13xforever Apologies what would be the best way to achieve that? |
if you don't know then it's ok, I'll just merge as is |
@13xforever Thank you! 👍 |
For #117