Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the order
requantize_with_max_scale
is called when loading a checkpoint using quark config.json/checkpoint format.Compare the following:
vllm/vllm/model_executor/layers/quantization/quark/schemes/quark_w8a8_fp8.py
Lines 35 to 48 in 6852819
normalize_e4m3fn_to_e4m3fnuz
should be called beforerequantize_with_max_scale
.