Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuda graph + num-scheduler-steps bug fix #236

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

seungrokj
Copy link

This is the same approach (vllm-project#8340) in vllm/attention/backends/utils.py to prevent the following error:

[rank0]:   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/vllm/worker/model_runner.py", line 869, in build
[rank0]:     attn_metadata = self.attn_metadata_builder.build(
[rank0]:   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/vllm/attention/backends/utils.py", line 223, in build
[rank0]:     input_block_tables[i, :len(block_table)] = block_table
[rank0]: ValueError: could not broadcast input array from shape (257,) into shape (256,)

@shajrawi @JArnoldAMD @andyluo7

shajrawi
shajrawi previously approved these changes Oct 16, 2024
Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@shajrawi
Copy link
Collaborator

Can you please the linter so we can merge it?

@shajrawi shajrawi merged commit 82cfa5a into main Oct 16, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants