Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mx num seqs expose to benchmark_throughput script #228

Closed
wants to merge 3 commits into from

Conversation

seungrokj
Copy link

@seungrokj seungrokj commented Oct 11, 2024

mx num seqs expose to benchmark_throughput script

@shajrawi @dllehr-amd @JArnoldAMD

Copy link
Collaborator

@shajrawi shajrawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the changes in benchmarks/profiling version of the *py benchmark files? This is our own copy we can change in rocm/vllm.

Changing the benchmarks/ folder scripts would require going through upstream first to avoid merge conflicts.

@seungrokj
Copy link
Author

Can you please make the changes in benchmarks/profiling version of the *py benchmark files? This is our own copy we can change in rocm/vllm.

Changing the benchmarks/ folder scripts would require going through upstream first to avoid merge conflicts.

@shajrawi
Sure will do! Thank you for the guidance!

@seungrokj seungrokj closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants