Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rpdtracer import only when required #216

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Make rpdtracer import only when required #216

merged 8 commits into from
Oct 3, 2024

Conversation

Rohan138
Copy link

@Rohan138 Rohan138 commented Sep 30, 2024 •
edited
Loading

Patch for #208 to make RPD imports optional

@charlifu
Copy link

charlifu commented Oct 1, 2024

Please run python3 -m pip install -r requirements-lint.txt && bash format.sh to fix the linter error.

gshtras
gshtras reviewed Oct 1, 2024
View reviewed changes
vllm/utils.py Show resolved Hide resolved
@Rohan138 Rohan138 force-pushed the ropotdar/move_rpdtracer_import branch from b13d624 to b05b3ce Compare October 1, 2024 18:55
@Rohan138 Rohan138 requested a review from gshtras October 1, 2024 18:56
@charlifu
Copy link

charlifu commented Oct 1, 2024 •
edited
Loading

https://github.com/ROCm/vllm/blob/main/vllm/worker/worker.py#L27
https://github.com/ROCm/vllm/blob/moe_sum/vllm/worker/model_runner.py#L1537
https://github.com/ROCm/vllm/blob/moe_sum/vllm/worker/model_runner.py#L50

@Rohan138 Rohan138 force-pushed the ropotdar/move_rpdtracer_import branch from 53fcaf3 to 83fa980 Compare October 1, 2024 22:16
@Rohan138
Copy link
Author

Rohan138 commented Oct 1, 2024

@charlifu I believe we need the other rpd_mark imports, but they will now no-op if the required library isn't installed.

@AdrianAbeyta could you take a look?

@AdrianAbeyta AdrianAbeyta self-requested a review October 2, 2024 21:11
@gshtras gshtras merged commit 47d6392 into main Oct 3, 2024
16 of 17 checks passed
@gshtras gshtras deleted the ropotdar/move_rpdtracer_import branch October 3, 2024 15:42
@Rohan138 Rohan138 restored the ropotdar/move_rpdtracer_import branch October 7, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshtras gshtras gshtras approved these changes

@dllehr-amd dllehr-amd Awaiting requested review from dllehr-amd

@AdrianAbeyta AdrianAbeyta Awaiting requested review from AdrianAbeyta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rohan138 @charlifu @gshtras