Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move utility tools from triton-mlir to main_perf branch #635

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

zhanglx13
Copy link

  • Plot layout script
  • occ.sh
  • amdgcn-cfg

@zhanglx13
Copy link
Author

@ravil-mobile Some formatter made some changes to the amdgcn-cfg tool. Can you double check everything is still working well?

Copy link
Collaborator

@brunomazzottiamd brunomazzottiamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go with respect to plot-layout and occ.sh. I'm not familiar with amdgcn-cfg, a thumbs up from someone that's used to it is required IMHO.

I also think we can move python/perf-kernels/tune_gemm to python/perf-kernels/tools/tune_gemm in a future PR so all tools would be in tools directory.

@zhanglx13
Copy link
Author

I think we're good to go with respect to plot-layout and occ.sh. I'm not familiar with amdgcn-cfg, a thumbs up from someone that's used to it is required IMHO.

I also think we can move python/perf-kernels/tune_gemm to python/perf-kernels/tools/tune_gemm in a future PR so all tools would be in tools directory.

This is a good idea. Let's do it here.

@zhanglx13 zhanglx13 merged commit 3704738 into main_perf Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants