[GEMM] [Tuning] Option to try different initialization strategies #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglx13
approved these changes
Jan 26, 2024
scripts/amd/gemm/tune_gemm.py
Outdated
| @@ -673,7 +690,7 @@ def main(): | |||
| print(f"Tuning starts at: {start_time}", flush=True) | |||
| f_results = open(tuning_output_file, 'w') | |||
|
|
|||
| for (M, N, K, col_a, col_b, myConfig) in mnks: | |||
| for (M, N, K, col_a, col_b, init_type, myConfig) in mnks: | |||
There was a problem hiding this comment.
I think we can remove init_type from mnks. All gemm sizes in a single tuning/benchmarking session can shared the same init_type
zhanglx13
force-pushed
the
gemm_init_types
branch
from
457a143
to
5938208
Compare
zhanglx13
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added init strategies: