-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove multiple archtictures to isa head and adding gemm tuning scripts #261
Conversation
scxiao
commented
Jul 13, 2023
- remove the code to include multiple versions of arch features to isa head
- Added a script to tune gemm performance (compatible with a script outside of this repo, may refine the script name later)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand the PR title (besides the typo to be fixed).
Or were the 2 other files not expected to be part of this PR?
This PR is for the MI300X bringup and for testing the MSFT workloads. To do the testing, there is a joint (AMD/MSFT) repository that requires these two scripts. I agree the name and location of the scripts are not good, but that is required by the other repository. I will fix that (rename the script and move them to a better location) in a later PR in this repo and the other repo, so they can still work together, |
Do we need |
I am not actually sure about that. Hi @alefimov-amd, what is your opinion on that? |
I asked because I saw you added it here: https://github.com/ROCmSoftwarePlatform/msft_amd_ai_operators/pull/172/files |
I see, in the script scripts/amd/gemm/tune_gemm.sh, there is the following line
to replace So everything will actually call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!