Added support for gfx950 architecture platform #2850
+61
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i. migrating third_party/mkl to @local_xla//xla/tsl/mkl ii. removal of cuda.h header iii. replace build_pip_package rule with wheel in build_rocm_python3 script
jayfurmanek
reviewed
Feb 12, 2025
| @@ -47,35 +47,22 @@ else | |||
| fi | |||
|
|
|||
| if [ -f /usertools/rocm.bazelrc ]; then | |||
| # Use the bazelrc files in /usertools if available | |||
There was a problem hiding this comment.
Reverted it. I added this to fix CI build, however it is only use for locally build. I may merge in separate PR if required
zahiqbal
force-pushed
the
gfx-architecture-support
branch
from
c928bb2 to
ed6bf74
Compare
| @@ -116,7 +116,8 @@ bool HasFastFP16Support(const DeviceProperties& props) { | |||
| #elif TENSORFLOW_USE_ROCM | |||
| absl::flat_hash_set<std::string> FP16SupportedDevices = { | |||
| {"gfx906"}, {"gfx908"}, {"gfx90a"}, {"gfx910"}, {"gfx940"}, {"gfx941"}, | |||
| {"gfx942"}, {"gfx1010"}, {"gfx1012"}, {"gfx1030"}, | |||
| {"gfx942"}, {"gfx950"}, | |||
There was a problem hiding this comment.
Is there any gfx that is not listed here at this point? Should we just return true?
| @@ -340,7 +340,8 @@ std::string MapGCNArchNameTokenToFeatureStr(const std::string& token, | |||
| return "+sramecc"; | |||
| } else if (token == "sramecc-") { | |||
| if (gfx == "gfx90a" || gfx == "gfx940" || gfx == "gfx941" || | |||
There was a problem hiding this comment.
I think we should remove this? This was a workaround for one specific machine. Albeit we might just do it unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.