Backport of 6.4.2 for cherry-pick list #714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding FP8 datatype to roofline feature in rocprof-compute on MI300-based systems. FP8 now shows in terminal output and roofline csv, and outputs a standalone PDF. --------- Signed-off-by: Carrie Fallows <[email protected]>
Signed-off-by: Carrie Fallows <[email protected]>
…608) Added debug log for when no flops are recorded (total_flops is 0), so AI points will not be plotted. Removed commented out print statement that is not functional- contains nonexistent method call. Signed-off-by: Carrie Fallows <[email protected]>
Added command line option to specify which datatype(s) to capture into the roofline PDF(s). All datatypes are still collected by roofline call if applicable, but only specific datatypes are plotted into PDF outputs. Will dump out all datatypes into one graph, but separate FP from Int into two graphs if needed. Will skip datatype and give error message if the datatype is not valid on a particular gpu arch. Default is FP32 Reworked roofline calls and plotting to be general enough such that any new datatypes added into rocm-amdgpu-bench can easily be reflected in rocprof-compute with simple modifications in roofline_calc.py. Adjusted ctest to reflect expected default pdf outputs from roofline. --------- Signed-off-by: Carrie Fallows <[email protected]>
Rebuild of rocm-amdgpu-bench roofline binaries for MI200/MI300 systems with rocm6. Added datatype options to roofline feature. --------- Signed-off-by: Carrie Fallows <[email protected]>
Profile mode: Fix roofline plots for datatypes that have peakVALU only. Check for highest roofline to plot the bandwidth lines to proper height, don't rely on existence of peakMFMA for every datatype. Analyze mode: Add roofline-data-type option for viewing pdfs in standalone gui. Default is same as profile mode, FP32. --------- Signed-off-by: Carrie Fallows <[email protected]>
…es (#702) Signed-off-by: Carrie Fallows <[email protected]>
Check mode before creating roofline object- skip if only printing specs Signed-off-by: Carrie Fallows <[email protected]>
Update formatting workflow to use 22.04. 20.04 deprecated last week. Signed-off-by: Carrie Fallows <[email protected]>
ywang103-amd
requested review from
koomie,
a team,
coleramos425,
feizheng10 and
dgaliffiAMD
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the replacement of "#708"