Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spellcheck delimiter for RST directives #516

Closed
wants to merge 1 commit into from

Conversation

samjwu
Copy link
Member

@samjwu samjwu commented Nov 17, 2023

Goal: to allow RST directives

Examples:

.. doxygenenum::

.. doxygenstruct::

@samjwu samjwu self-assigned this Nov 17, 2023
@samjwu
Copy link
Member Author

samjwu commented Nov 17, 2023

@saadrahim
Copy link
Member

Can you separate the delimiters for rst from the word list update?

@samjwu
Copy link
Member Author

samjwu commented Nov 20, 2023

Can you separate the delimiters for rst from the word list update?

#527

@@ -12,7 +12,10 @@ matrix:
- pyspelling.filters.context:
context_visible_first: true
delimiters:
# ReST: code blocks
# RST directives
- open: '^\.{2}[ ]+[a-z-]+[:]{2}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neon60 how do you think this will interact with the other code block sections that were added?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing locally. The code block check also not working correctly, I need more time to be able to answer the question.

@neon60
Copy link
Contributor

neon60 commented Nov 22, 2023

Find a better way to handle the ReST of spellcheck, we should probably just close this PR.
We will discuss this during the today's standup.

@samjwu
Copy link
Member Author

samjwu commented Nov 22, 2023

#530

@samjwu samjwu closed this Nov 22, 2023
@samjwu samjwu deleted the rst-spell branch March 9, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants