-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve spellcheck script to allow for projects to specify additional sources #1100
Conversation
4a04c4b
to
8a5852a
Compare
8a5852a
to
0e4557c
Compare
0e4557c
to
a453c74
Compare
4ab21b9
to
65b043c
Compare
69d5c3a
to
d9b629d
Compare
Here is a test action in the HIP repository that shows the spellcheck run https://github.com/ROCm/HIP/actions/runs/12868847369/job/35990222242 And in the ROCm repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may belong to ci: instead of feat: since it's affecting workflow files (for the commitizen commit message)
is there a need to release a new version for this?
d9b629d
to
c9ec557
Compare
Thanks for pointing that out, squashed and adjusted the commit message. Spoke to @neon60 about the need to release and he says no. |
This PR contains the following update:
.spellcheck.yaml
.spellcheck.local.yaml
that can be used as a reference for other projects when they want to specify additional sourcesdocs/yaml_merger.py
to merge any project's.spellcheck.local.yaml
with the main.spellcheck.yaml
in this repository. The script simply checks the nodesname
andsource
and ensures they match before merging the additional sources (node depth must match too). Anything else is ignored.