Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake][rocRAND] Updated toolchain-linux.cmake to have proper CMAKE_PREFIX_PATH definitions #587

Merged
merged 15 commits into from
Dec 31, 2024
Merged

[cmake][rocRAND] Updated toolchain-linux.cmake to have proper CMAKE_PREFIX_PATH definitions #587

merged 15 commits into from
Dec 31, 2024

Conversation

NguyenNhuDi
Copy link
Collaborator

No description provided.

@NguyenNhuDi NguyenNhuDi marked this pull request as draft November 20, 2024 21:27
amd-jnovotny
amd-jnovotny approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good overall. Just one section header change and an editorial suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
NguyenNhuDi and others added 2 commits November 20, 2024 14:32
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
6b1466b 
Co-authored-by: Jeffrey Novotny <[email protected]>
@NguyenNhuDi @amd-jnovotny
Update CHANGELOG.md
a65d0cc 
Co-authored-by: Jeffrey Novotny <[email protected]>
@NguyenNhuDi NguyenNhuDi marked this pull request as ready for review November 20, 2024 23:12
@NguyenNhuDi
Copy link
Collaborator Author

NguyenNhuDi commented Nov 21, 2024 •
edited
Loading

Updated various CMAKE files.

  • Moved the position of variable definitions to the top in CMAKELists
  • Edited toolchain-linux to define CMAKE_PREFIX_PATH as well
  • Removed a part of Dependencies.cmake where it forces the CMAKE_CXX_COMPILER for benchmarks to be cl or g++ if it was not GNU

amd-jnovotny
amd-jnovotny reviewed Nov 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@NguyenNhuDi NguyenNhuDi merged commit ad8cdd8 into ROCm:develop Dec 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@stanleytsang-amd stanleytsang-amd stanleytsang-amd approved these changes

@umfranzw umfranzw Awaiting requested review from umfranzw umfranzw is a code owner

@RobsonRLemos RobsonRLemos Awaiting requested review from RobsonRLemos RobsonRLemos is a code owner

@lawruble13 lawruble13 Awaiting requested review from lawruble13 lawruble13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NguyenNhuDi @stanleytsang-amd @amd-jnovotny