Skip to content

Commit

Permalink
changed default boolean (kaunchGraph, sync) to be true in createAndLa…
Browse files Browse the repository at this point in the history
…unchGraph
  • Loading branch information
NguyenNhuDi committed Oct 3, 2024
1 parent d958870 commit 67d34d7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
18 changes: 9 additions & 9 deletions test/test_rocrand_hipgraphs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,22 @@ void test_float(std::function<rocrand_status(rocrand_generator, float*, size_t,
ROCRAND_CHECK(
generate_fn(generator, data, 1, mean, stddev)
);
gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

// Any alignment
ROCRAND_CHECK(
generate_fn(generator, data+1, 2, mean, stddev)
);

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

ROCRAND_CHECK(
generate_fn(generator, data, size, mean, stddev)
);

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);

HIP_CHECK(hipFree(data));
ROCRAND_CHECK(rocrand_destroy_generator(generator));
Expand Down Expand Up @@ -117,22 +117,22 @@ TEST_P(rocrand_hipgraph_generate_tests, uniform_float_test)
rocrand_generate_uniform(generator, data, 1)
);

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

// Any alignment
ROCRAND_CHECK(
rocrand_generate_uniform(generator, data+1, 2)
);

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

ROCRAND_CHECK(
rocrand_generate_uniform(generator, data, size)
);

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);

HIP_CHECK(hipFree(data));
ROCRAND_CHECK(rocrand_destroy_generator(generator));
Expand Down Expand Up @@ -165,18 +165,18 @@ TEST_P(rocrand_hipgraph_generate_tests, poisson_test)
// Any sizes
ROCRAND_CHECK(rocrand_generate_poisson(generator, data, 1, 10.0));

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

// Any alignment
ROCRAND_CHECK(rocrand_generate_poisson(generator, data + 1, 2, 500.0));

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);
gHelper.resetGraphHelper(stream);

ROCRAND_CHECK(rocrand_generate_poisson(generator, data, size, 5000.0));

gHelper.createAndLaunchGraph(stream, true, true);
gHelper.createAndLaunchGraph(stream);

HIP_CHECK(hipFree(data));
ROCRAND_CHECK(rocrand_destroy_generator(generator));
Expand Down
4 changes: 2 additions & 2 deletions test/test_utils_hipgraphs.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ namespace test_utils
HIP_CHECK_NON_VOID(hipStreamEndCapture(stream, &graph));
}

inline void createAndLaunchGraph(hipStream_t & stream, const bool launchGraph=false, const bool sync=false){
inline void createAndLaunchGraph(hipStream_t & stream, const bool launchGraph=true, const bool sync=true){

HIP_CHECK_NON_VOID(hipGraphInstantiate(&graph_instance, graph, nullptr, nullptr, 0));

Expand All @@ -69,7 +69,7 @@ namespace test_utils
if(beginCapture)
startStreamCapture(stream);

createAndLaunchGraph(stream, true, true);
createAndLaunchGraph(stream);
}

inline void launchGraphHelper(hipStream_t& stream,const bool sync=false)
Expand Down

0 comments on commit 67d34d7

Please sign in to comment.