[release/2.6][SWDEV-523736] Skip&Fix some testcases for archs without SDPA or Navi4x #2213
+51
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pruthvistony please have a look. |
k-artem
changed the title
pruthvistony
requested changes
Jun 6, 2025
| @@ -10611,6 +10611,7 @@ def fn(q, k, v): | |||
| ) | |||
|
|
|||
| @expectedFailureXPU | |||
| @unittest.skipIf(not PLATFORM_SUPPORTS_FLASH_ATTENTION, "Some archs don't support SDPA") | |||
There was a problem hiding this comment.
SDPA is support for Navi4 through AOTriton, we shouldnt skip the whole test
There was a problem hiding this comment.
It's true for Navi48, but not for Navi44, currently no support it but it's planned as experimental in AOTriton 0.10.
|
Jenkins build for 5d697ad2d52d7d659dc4cc2fb76f7a224dc7b2a3 commit finished as FAILURE |
k-artem
changed the title
|
The commit updated, pruthvistony please have a look. |
|
Jenkins build for 03c4453a242a92f069a50552f0592ba3a38f46ee commit finished as FAILURE |
* Most part of testcases work properly on Navi48(gfx1201) with TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1, in this commit enable it for this arch. No support of AOTriton currently for Navci44(gfx1200), so these testcases just skipped. * test_qconv2d_int8_mixed_bf16 skipped because it was originally skipped in pytorch#112550 but later lost. * test_sac_ilp_case1 skipped as per SWDEV-509011 * test_distributed_checkpoint_state_dict_type[0-1]_cuda fixed bug with arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[release/2.6][SWDEV-523736] Skip some testcases for archs without SDPA or Navi4x
[SWDEV-523736] Fix some unittests for Navi4x
TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1, in this commit enable it
for this arch. No support of AOTriton currently for Navci44(gfx1200),
so these testcases just skipped.
[Inductor] [Quant] Enable QConv2d Unary int8-mixed-bf16 Lowering pytorch/pytorch#112550 but later lost.
with arguments.
Fixes #SWDEV-523736