-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocm6.4 IFU CP 09122024 #1596
rocm6.4 IFU CP 09122024 #1596
Commits on Sep 13, 2024
-
[SOW MS3] Centos stream9 PyTorch image support (#1090)
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 98cc4e1 - Browse repository at this point
Copy the full SHA 98cc4e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d6126 - Browse repository at this point
Copy the full SHA 05d6126View commit details -
Temporarily skip test_conv3d_64bit_indexing
- Rocblas API support is requested - SWDEV-383635 & sub task - SWDEV-390218
Configuration menu - View commit details
-
Copy full SHA for dd31176 - Browse repository at this point
Copy the full SHA dd31176View commit details -
Enable tensorpipe with hip_basic backend (#1135)
* Add hip_basic tensorpipe support to PyTorch * Enabling hip_basic for Tensorpipe for pyTorch * removing upstream tensorpipe module * Adding ROCm specific tensopipe submodule * tensorpipe submodule updated * Update the hip invalid device string * Added ignore for tensorpipe git submodule * Moved include of tensorpipe_cuda.h to hipify * Updates based on review comments * Defining the variable __HIP_PLATFORM_AMD__ * Enabling the UTs Co-authored-by: Ronak Malik <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e96aba2 - Browse repository at this point
Copy the full SHA e96aba2View commit details -
- Fortran package installation moved after gcc - Update libtinfo search code in cmake1 - Install libstdc++.so
Configuration menu - View commit details
-
Copy full SHA for 8fffb23 - Browse repository at this point
Copy the full SHA 8fffb23View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbd0b44 - Browse repository at this point
Copy the full SHA cbd0b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9923275 - Browse repository at this point
Copy the full SHA 9923275View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0697b9 - Browse repository at this point
Copy the full SHA b0697b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fd6e13 - Browse repository at this point
Copy the full SHA 4fd6e13View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2de668 - Browse repository at this point
Copy the full SHA f2de668View commit details -
Configuration menu - View commit details
-
Copy full SHA for e83f564 - Browse repository at this point
Copy the full SHA e83f564View commit details -
Skip ddp apply_optim_in_bwd tests for gloo (#1302)
To resolve https://ontrack-internal.amd.com/browse/SWDEV-403530 and https://ontrack-internal.amd.com/browse/SWDEV-419837. For more context check upstream issue pytorch#111834
Configuration menu - View commit details
-
Copy full SHA for b56588b - Browse repository at this point
Copy the full SHA b56588bView commit details -
Reversed the condition as required
Configuration menu - View commit details
-
Copy full SHA for e59bfe3 - Browse repository at this point
Copy the full SHA e59bfe3View commit details -
[CS9] Updates to CentOS stream 9 build (#1326)
- Add missing common_utils.sh - Update the install vision part - Move to amdgpu rhel 9.3 builds - Update to pick python from conda path - Add a missing package - Add ROCM_PATH and magma - Updated repo radeon path
Configuration menu - View commit details
-
Copy full SHA for 281e2bf - Browse repository at this point
Copy the full SHA 281e2bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for eea29cd - Browse repository at this point
Copy the full SHA eea29cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5067c2 - Browse repository at this point
Copy the full SHA e5067c2View commit details -
Enable gesvda for ROCM >= 6.1 (#1339)
This also fixes a problem in gesvd driver when UV is not needed.
Configuration menu - View commit details
-
Copy full SHA for 2be2a79 - Browse repository at this point
Copy the full SHA 2be2a79View commit details -
Increase lifespan of test-times files
- build_environment is hard coded to value from upstream when branch for created, since the dev/QA ENV build_environment value can be varing
Configuration menu - View commit details
-
Copy full SHA for 8f6c7af - Browse repository at this point
Copy the full SHA 8f6c7afView commit details -
* Fix the parsing of /etc/os-release The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus never links to libtinfo correctly. * Configurable CMAKE_PREFIX_PATH in CI script.
Configuration menu - View commit details
-
Copy full SHA for f1f2b4e - Browse repository at this point
Copy the full SHA f1f2b4eView commit details -
[NO CP] Temporary dumping of test exec log to stderr
- This is done as per QA request, needs to be reverted and not required to be cherry-picked into later releases.
Configuration menu - View commit details
-
Copy full SHA for d98149c - Browse repository at this point
Copy the full SHA d98149cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a4d1e2 - Browse repository at this point
Copy the full SHA 8a4d1e2View commit details -
Converted NAVI check as a function (#1364)
* Moved NAVI check to the test file * Revised NAVI check as a function
Configuration menu - View commit details
-
Copy full SHA for 5b77292 - Browse repository at this point
Copy the full SHA 5b77292View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c93554 - Browse repository at this point
Copy the full SHA 4c93554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7da900e - Browse repository at this point
Copy the full SHA 7da900eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aba300 - Browse repository at this point
Copy the full SHA 4aba300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5580969 - Browse repository at this point
Copy the full SHA 5580969View commit details -
Skip test_mm_triton_kernel_benchmark (#1376)
* Running triton kernel on ROCM only has one GB/s metric reported * Update test_kernel_benchmark.py
Configuration menu - View commit details
-
Copy full SHA for 183802e - Browse repository at this point
Copy the full SHA 183802eView commit details -
temporarily ignore certificate check for Miniconda
(cherry picked from commit 9848db1)
Configuration menu - View commit details
-
Copy full SHA for 90c132a - Browse repository at this point
Copy the full SHA 90c132aView commit details -
Implementation of PyTorch ut parsing script - QA helper function (#1386)
* Initial implementation of PyTorch ut parsing script * Extracted path variables * Use nested dict to save results * Fixes typo * Cleanup * Fixes several issues * Minor name change * Update run_pytorch_unit_tests.py * Added file banners * Supported running from API * Added more help info * Consistent naming * Format help text --------- Co-authored-by: Jithun Nair <[email protected]> Co-authored-by: Jithun Nair <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0d89328 - Browse repository at this point
Copy the full SHA 0d89328View commit details -
Configuration menu - View commit details
-
Copy full SHA for f47dca8 - Browse repository at this point
Copy the full SHA f47dca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e27ff6e - Browse repository at this point
Copy the full SHA e27ff6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ae8e99 - Browse repository at this point
Copy the full SHA 0ae8e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed694e4 - Browse repository at this point
Copy the full SHA ed694e4View commit details -
[release/2.1] Skip certificate check for CentOS7 since certificate ex…
…pired (#1399) * Skip certificate check only for CentOS7 since certificate expired * Naming
Configuration menu - View commit details
-
Copy full SHA for 6876373 - Browse repository at this point
Copy the full SHA 6876373View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dade27 - Browse repository at this point
Copy the full SHA 7dade27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e12b31 - Browse repository at this point
Copy the full SHA 6e12b31View commit details -
Change Torch extra install requirement
- PYTORCH_EXTRA_INSTALL_REQUIREMENTS is set in builder repo - Remove the PYTORCH_EXTRA_INSTALL_REQUIREMENTS step from this file
Configuration menu - View commit details
-
Copy full SHA for d4d80ee - Browse repository at this point
Copy the full SHA d4d80eeView commit details -
Remove the installation of rocm-llvm-dev package
- Causing regression - SWDEV-463083
Configuration menu - View commit details
-
Copy full SHA for e6ff669 - Browse repository at this point
Copy the full SHA e6ff669View commit details -
* Fix SWDEV-459623. The Rank of logsumexp Tensor must be 3. This tensor was considered for internal use only but apparently exposed to UTs. * Fix for mGPU. The stream should be selected after picking the current device according to input tensor.
Configuration menu - View commit details
-
Copy full SHA for da0e1b4 - Browse repository at this point
Copy the full SHA da0e1b4View commit details
Commits on Sep 16, 2024
-
Enable fp8 inductor unit tests (#1421)
* Add formal FP8 check in common_cuda.py * Enable inductor/test_valid_cast * Support for test_eager_fallback * allow fnuz types on amax test * Finalize passing tests vs failing * Fix fnuz constants in _to_fp8_saturated
Configuration menu - View commit details
-
Copy full SHA for 4b8aea1 - Browse repository at this point
Copy the full SHA 4b8aea1View commit details -
Enable NHWC batchnorm for miopen (#1400)
* Enable batchnorm NHWC for MIOpen * cleanup * test to compare NHWC MIOpen batchnorm with CPU * fix 'use_miopen' condition for nhwc miopen * fix includes * use native nhwc batchnorm to verify miopen * remove extra spaces * remove empty lines * set PYTORCH_MIOPEN_SUGGEST_NHWC=1 for all test_nn.py test
Configuration menu - View commit details
-
Copy full SHA for 4c94122 - Browse repository at this point
Copy the full SHA 4c94122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c85c6c - Browse repository at this point
Copy the full SHA 4c85c6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d10d2fa - Browse repository at this point
Copy the full SHA d10d2faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93c7b7f - Browse repository at this point
Copy the full SHA 93c7b7fView commit details -
Print consolidated log file for pytorch unit test automation scripts (#…
…1433) * Print consolidated log file for pytorch uts * Update run_entire_tests subprocess call as well * lint * Add ERROR string
Configuration menu - View commit details
-
Copy full SHA for bf3a2cd - Browse repository at this point
Copy the full SHA bf3a2cdView commit details -
[ROCm] Intra-node all reduce initial implementation (#1435)
* Initial commit to port intra_node_comm to ROCm (cherry picked from commit 48d1c33) * gpt-fast running now with intra-node comm (cherry picked from commit 618c54e) --------- Co-authored-by: Prachi Gupta <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5641fa - Browse repository at this point
Copy the full SHA a5641faView commit details -
Sync updates from hipify_torch. (#1168)
Co-authored-by: Jithun Nair <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7f7d24b - Browse repository at this point
Copy the full SHA 7f7d24bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3201b0 - Browse repository at this point
Copy the full SHA d3201b0View commit details -
[SWDEV-466849] Enhancements for PyTorch UT helper scripts (#1491)
* Check that >1 GPUs are visible when running TEST_CONFIG=distributed * Add EXECUTION_TIME to file-level and aggregate statistics
Configuration menu - View commit details
-
Copy full SHA for a82ac7b - Browse repository at this point
Copy the full SHA a82ac7bView commit details -
Added functions imports (#1521)
Fixes inductor.test_torchinductor_dynamic_shapes::TestInductorDynamicCUDA::test_item_unbacked_stride_nobreak_cuda
Configuration menu - View commit details
-
Copy full SHA for 2ec0172 - Browse repository at this point
Copy the full SHA 2ec0172View commit details -
PyTorch unit test helper scripts enhancements (#1517)
* Fail earlier for distributed-on-1-GPU scenario * print cmd in consolidated log with prettier formatting * python->python3 Fixes https://ontrack-internal.amd.com/browse/SWDEV-477264 --------- Co-authored-by: blorange-amd <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8c1fa06 - Browse repository at this point
Copy the full SHA 8c1fa06View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ebe30 - Browse repository at this point
Copy the full SHA e3ebe30View commit details -
[rocm6.3_internal_testing] pin sympy==1.12.1 and skip pytorch-nightly…
… installstion (#1557) This PR pins sympy==1.12.1 in the .ci/docker/requirements-ci.txt file Also it skips pytorch-nightly installation in docker images Installation of pytorch-nightly is needed to prefetch mobilenet_v2 avd v3 models for some tests. Came from 85bd6bc Models are downloaded on first use to the folder /root/.cache/torch/hub But pytorch-nightly installation also overrides .ci/docker/requirements-ci.txt settings and upgrades some of python packages (sympy from 1.12.0 to 1.13.0) which causes several 'dynamic_shapes' tests to fail Skip prefetching models affects these tests without any errors (but **internet access required**): - python test/mobile/model_test/gen_test_model.py mobilenet_v2 - python test/quantization/eager/test_numeric_suite_eager.py -k test_mobilenet_v3 Issue ROCm/frameworks-internal#8772 Also, in case of some issues these models can be prefetched after pytorch building and before testing (cherry picked from commit b92b34d) Fixes #ISSUE_NUMBER
Configuration menu - View commit details
-
Copy full SHA for 5b9a211 - Browse repository at this point
Copy the full SHA 5b9a211View commit details -
Add test_batchnorm_nhwc_miopen_cuda_float32 (#1561)
New tests introduced for testing NHWC and NCHW batchnorm on MIOpen : - test_batchnorm_nhwc_miopen_cuda_float32 - test_batchnorm_nchw_miopen_cuda_float32 This test verifies weight and bias gradients, running_mean and running_var We can add other dtypes later How to run: `MIOPEN_ENABLE_LOGGING_CMD=1 python -u test/test_nn.py -v -k test_batchnorm_nhwc_miopen_cuda_float32` There is a difference in running_variance for NHWC batchnorm fp32 between MIOpen and native ``` MIOPEN_ENABLE_LOGGING_CMD=1 python -u test/test_nn.py -v -k test_batchnorm_nhwc_miopen_cuda_float32 ... self.assertEqual(mod.running_var, ref_mod.running_var) AssertionError: Tensor-likes are not close! Mismatched elements: 8 / 8 (100.0%) Greatest absolute difference: 0.05455732345581055 at index (5,) (up to 1e-05 allowed) Greatest relative difference: 0.030772637575864792 at index (5,) (up to 1.3e-06 allowed) ```
Configuration menu - View commit details
-
Copy full SHA for 5783557 - Browse repository at this point
Copy the full SHA 5783557View commit details -
Imported skipIfRocm in certain test suites (#1577)
Fixes SWDEV-472397
Configuration menu - View commit details
-
Copy full SHA for 115944d - Browse repository at this point
Copy the full SHA 115944dView commit details -
[SWDEV-473498] Pin sympy for >=python3.9 (#1576)
Cherry pick pytorch#133235 Fixes SWDEV-473498
Configuration menu - View commit details
-
Copy full SHA for ac86642 - Browse repository at this point
Copy the full SHA ac86642View commit details -
Several issues fix of QA helper script (#1564)
Fixes SWDEV-475071: https://ontrack-internal.amd.com/browse/SWDEV-475071
Configuration menu - View commit details
-
Copy full SHA for 9833f2d - Browse repository at this point
Copy the full SHA 9833f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 524bef2 - Browse repository at this point
Copy the full SHA 524bef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccdc413 - Browse repository at this point
Copy the full SHA ccdc413View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae08f9f - Browse repository at this point
Copy the full SHA ae08f9fView commit details