Update Perfetto and fix tests #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaliffiAMD
reviewed
Sep 6, 2024
Adding DOMNITRACE_INSTALL_PERFETTO_TOOLS=ON to ubuntu-jammy workflow
This warning / error is generated when we also compile the perfetto tools: /src/trace_processor/trace_processor_shell.c Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
This reverts commit 891a199. We'll move this to it's own PR.
Remove the INSTALL_PERFETTO_TOOLS and add `pip install --upgrade perfetto` Signed-off-by: David Galiffi <[email protected]>
Check if the provided path to trace_processor is valid before using Enable verbose logging for testing Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
This reverts commit 92dbecb.
Signed-off-by: David Galiffi <[email protected]>
dgaliffiAMD
changed the title
|
FYI - I just removed the internal JIRA link from the commit description. |
dgaliffiAMD
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for "SWDEV-479652" - Perfetto-based tests are failing.