-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tarball on rocm tags and MAINTAINERS guide #402
Conversation
…utline release procedure Signed-off-by: coleramos425 <[email protected]>
@koomie please feel free to add any feedback if there's anything I missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks good. Just some minor formatting changes.
b9567b3
to
1b2a75e
Compare
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Some feedback from ROCm devops team on this PR (via @WBobby)
TODO
|
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
56cf357
to
8395f67
Compare
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
I've modified the packaging workflow so that on a new tag (including tags matching the format omniperf/.github/workflows/packaging.yml Lines 48 to 62 in 7441f04
This should comply with requirements from the DevOps team and their "rocm-ci" bot used to trigger releases. |
Signed-off-by: coleramos425 <[email protected]>
After meeting with @arjun-raj-kuppala we've decided that instead of triggering the packaging workflow on tag, we should trigger on release and then upload the subsequent tarball artifact to the latest release as an asset. It's a little different than what I'm doing now, but should be an easy change. Other than that, this PR complies on his end. |
Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: xuchen-amd <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: xuchen-amd <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: xuchen-amd <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]> Signed-off-by: xuchen-amd <[email protected]>
This PR adds a
MAINTAINERS.md
file which outlines the procedure for publishing an Omniperf release. The guide should be shared with any project maintainers who will be publishing releases.I've also modified the
packaging.yml
action such that any tags matching regexrocm-[0-9]+.[0-9]+.[0-9]+*
will trigger the workflow which produces our release tarball.TODO:
amd-mainline
andamd-staging
branches, update the empty links in the MAINTAINERS.md file