Use compressed debug symbols #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CongMa13
requested review from
cgmillette,
bragadeesh,
mkarunan,
dlangbe and
afanfa
as code owners
cgmillette
reviewed
Mar 11, 2024
The size of file will be greater than 2G in Debug and RelWithDebug mode. The use of compressed debug symbols significantly reduces library size, avoiding the need to remove targets in the address sanitizer build. The non-address sanitizer debug builds didn't drop GPU targets, but shared the same library size problem as the address sanitizer build. This change will also fix those builds.
cgmillette
approved these changes
Mar 11, 2024
dlangbe
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of file will be greater than 2G in Debug and RelWithDebug mode.
The use of compressed debug symbols significantly reduces library size, avoiding the need to remove targets in the address sanitizer build. The non-address sanitizer debug builds didn't drop GPU targets, but shared the same library size problem as the address sanitizer build. This change will also fix those builds.