Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FlatWGS attribute is not null before inspecting #160

Open
wants to merge 1 commit into
base: clang_tot_upgrade
Choose a base branch
from

Conversation

acowley
Copy link

@acowley acowley commented Oct 24, 2018

The lack of this check was causing segfaults for me when compiling some things with hcc but not others. My bug hunt narrowed down to failing miopen-hip tests on my machine. The larger context is that I have all ROCm pieces compiled from source on NixOS, starting with a build environment including gcc-7.3.0.

Earlier logic in this function as found in upstream clang looked like this,

unsigned Min = FlatWGS ? FlatWGS->getMin() : 0;
unsigned Max = FlatWGS ? FlatWGS->getMax() : 0;

but the check that FlatWGS is not null was lost along the way.

@scchan scchan requested a review from yxsamliu November 29, 2018 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants