Ensure FlatWGS attribute is not null before inspecting #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of this check was causing segfaults for me when compiling some things with
hcc
but not others. My bug hunt narrowed down to failingmiopen-hip
tests on my machine. The larger context is that I have all ROCm pieces compiled from source on NixOS, starting with a build environment including gcc-7.3.0.Earlier logic in this function as found in upstream
clang
looked like this,but the check that
FlatWGS
is not null was lost along the way.